chore: fix clippy lints

Cargo.toml

@@ -1,6 +1,7 @@
 [package]
 name = "rustypipe"
 version = "0.1.3"
+rust-version = "1.67.1"
 edition.workspace = true
 authors.workspace = true
 license.workspace = true

cli/Cargo.toml

@@ -1,6 +1,7 @@
 [package]
 name = "rustypipe-cli"
 version = "0.1.0"
+rust-version = "1.74.0"
 edition.workspace = true
 authors.workspace = true
 license.workspace = true

codegen/Cargo.toml

@@ -1,6 +1,7 @@
 [package]
 name = "rustypipe-codegen"
 version = "0.1.0"
+rust-version = "1.74.0"
 edition.workspace = true
 authors.workspace = true
 license.workspace = true

codegen/src/model.rs

@@ -67,12 +67,12 @@ pub struct TimeAgo {
     pub unit: TimeUnit,
 }
 
-impl ToString for TimeAgo {
-    fn to_string(&self) -> String {
+impl std::fmt::Display for TimeAgo {
+    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
         if self.n > 1 {
-            format!("{}{}", self.n, self.unit.as_str())
+            write!(f, "{}{}", self.n, self.unit.as_str())
         } else {
-            self.unit.as_str().to_owned()
+            f.write_str(self.unit.as_str())
         }
     }
 }

downloader/Cargo.toml

@@ -1,6 +1,7 @@
 [package]
 name = "rustypipe-downloader"
 version = "0.1.0"
+rust-version = "1.67.1"
 edition.workspace = true
 authors.workspace = true
 license.workspace = true

src/client/player.rs

@@ -429,7 +429,7 @@ fn deobf_nsig(
         } else {
             let nsig = deobf.deobfuscate_nsig(n)?;
             last_nsig[0] = n.to_string();
-            last_nsig[1] = nsig.clone();
+            last_nsig[1].clone_from(&nsig);
             nsig
         };
 

src/client/response/music_item.rs

@@ -721,7 +721,7 @@ impl MusicListMapper {
                                     .unwrap_or_default()
                             }))
                     {
-                        artists = fb_artists.clone();
+                        artists.clone_from(fb_artists);
                     }
                 }
 
@@ -787,7 +787,7 @@ impl MusicListMapper {
                         // fall back to menu data
                         if let Some(a1) = artists.first_mut() {
                             if a1.id.is_none() {
-                                a1.id = artist_id.clone();
+                                a1.id.clone_from(&artist_id);
                             }
                         }
 

src/model/mod.rs

@@ -68,9 +68,9 @@ pub enum UrlTarget {
     },
 }
 
-impl ToString for UrlTarget {
-    fn to_string(&self) -> String {
-        self.to_url()
+impl std::fmt::Display for UrlTarget {
+    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
+        f.write_str(&self.to_url())
     }
 }
 

src/serializer/text.rs

@@ -658,9 +658,12 @@ impl TextComponents {
     }
 }
 
-impl ToString for TextComponents {
-    fn to_string(&self) -> String {
-        self.0.iter().map(TextComponent::as_str).collect::<String>()
+impl std::fmt::Display for TextComponents {
+    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
+        for t in &self.0 {
+            f.write_str(t.as_str())?;
+        }
+        Ok(())
     }
 }
 

src/util/mod.rs

@@ -284,6 +284,7 @@ pub fn div_ceil(a: u32, b: u32) -> u32 {
     }
 }
 
+#[allow(dead_code)]
 pub trait TryRemove<T> {
     /// Removes and returns the element at position `index` within the vector,
     /// shifting all elements after it to the left.